• 0 Posts
  • 4 Comments
Joined 9 months ago
cake
Cake day: June 4th, 2025

help-circle
  • Sure, that would be a little different, but unless you could make a convincing argument, backed up with a solid set of unit tests, at the least, as to why and how you were able to remove that much code whilst only adding a comparatively small amount, I’d still be inclined to reject it and ask for it to be broken down into smaller units.

    Now, that explaination might be something along the lines of it being dead code that is not called from anywhere, or even that it was a patched version of an upstream library, and the patch is now included in that upstream, in which case, fair enough, good work, and thanks very much. As a rewrite or refactor though, it’s too big to sensibly review and needs breaking down into separate features.


  • I’m assuming this is some sort of canary message to indicate that the code base has been compromised, the author can’t talk about it, and everyone should immediately stop using the service. Surely no-one would be unwise enough to commit this otherwise?

    Even ignoring the huge red LLM flag, a 25kLOC delta in a single PR should be cause for instant rejection as there’s no way to fully understand or test it, let alone in 2-3 weeks.


  • If you’re using this script to convert something that isn’t self-contained, you are further into the abyss than I ever ventured, and I am certain it will end terribly.

    Hmm, does this handle CRDs and operators? My setup depends quite heavily on them you see. My application manifests use services and operators defined in my core manifests. Everything works together like a finely oiled machine rotating through a few too many dimensions. I do not remember why it works. The abyss calls to me, whispering of self configuring services. The undying light calls to me, with promises of simpler systems and less madness. I hesitate, and turn towards the abyss…

    Yog Sa’rath, stay away from me.

    After witness this creation, even Yog Sa`rath is eyeing you wearily and giving you a wide berth, recognising one of their own, who has risen above the rest.